Skip to content

Conversation

@NorOldBurden
Copy link
Contributor

No description provided.

connection: true,
},
schemasByApiSchemaApiIdAndSchemaId: {
schemataByApiSchemaApiIdAndSchemaId: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like the OLD naming!

@NorOldBurden NorOldBurden force-pushed the fix/codegen-server-issue branch from ca0e2cf to 1bbf3ca Compare January 19, 2026 06:52
@yyyyaaa
Copy link
Contributor

yyyyaaa commented Jan 19, 2026

I have a few questions:
The PR could have simply been:

  1. Add headers to GenerateOptions interface
  2. Pass options.headers through to fetchSchema()
  3. Add CLI --header parsing
    Why did we remove fetch here? fetch is supported anywhere and simply works.

Was there a specific bug with fetch (SSL issues, proxy problems, Node version compatibility)?

@yyyyaaa
Copy link
Contributor

yyyyaaa commented Jan 19, 2026

Was Host header override the specific issue you hit? Can you share the error or scenario? I need to know the exact scenario that's not working that you run into here. Plz provide some steps to reproduce

@NorOldBurden
Copy link
Contributor Author

Was Host header override the specific issue you hit? Can you share the error or scenario? I need to know the exact scenario that's not working that you run into here. Plz provide some steps to reproduce

As I showed back in the meeting
https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch
https://developer.mozilla.org/en-US/docs/Glossary/Forbidden_request_header
The fetch doesn't support for the list forbidden list override where host is one of them.

@NorOldBurden NorOldBurden force-pushed the fix/codegen-server-issue branch from b35ce1a to 3261c95 Compare January 19, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants