applied makage and standardize the pkg in jobs and fns #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anmol1696
reviewed
Jan 19, 2026
| process.env.PGDATABASE = 'jobs'; | ||
| process.env.JOBS_SCHEMA = 'app_jobs'; | ||
| process.env.INTERNAL_JOBS_CALLBACK_URL = | ||
| process.env.JOBS_CALLBACK_BASE_URL = |
Contributor
There was a problem hiding this comment.
are we changing the env variables?? this will start breaking what we have in the cloud.
If we change anything here, can we outline it properly in the PR so we can make related changes in the cloud PR
Contributor
Author
There was a problem hiding this comment.
Ah, sorry, I think this's confused by the JOBS_CALLBACK_BASE_URL usage in getCallbackBaseUrl like:
export const getCallbackBaseUrl = (): string => {
if (process.env.JOBS_CALLBACK_BASE_URL) {
return process.env.JOBS_CALLBACK_BASE_URL;
}
const host = process.env.JOBS_CALLBACK_HOST || 'jobs-callback';
const port = getJobsCallbackPort();
return http://${host}:${port}/callback;
};
I think I should change JOBS_CALLBACK_BASE_URL here to INTERNAL_JOBS_CALLBACK_URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.