Skip to content

Replacing setTextValue → setText, setText2Value → setText2, setDescriptionValue → setDescription#289

Merged
VISTALL merged 1 commit intoconsulo:masterfrom
unv-unv:eliminating-set-text-value
Apr 7, 2026
Merged

Replacing setTextValue → setText, setText2Value → setText2, setDescriptionValue → setDescription#289
VISTALL merged 1 commit intoconsulo:masterfrom
unv-unv:eliminating-set-text-value

Conversation

@unv-unv
Copy link
Copy Markdown
Contributor

@unv-unv unv-unv commented Apr 6, 2026

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates action/presentation/progress text APIs to use the newer setText / setText2 / setDescription methods in place of the older *Value variants.

Changes:

  • Replaced Presentation.setTextValue(...) with Presentation.setText(...) across multiple actions.
  • Replaced ProgressIndicator.setTextValue(...) / setText2Value(...) with setText(...) / setText2(...).
  • Replaced Presentation.setDescriptionValue(...) with setDescription(...), plus a small setEnabledAndVisible(true) cleanup.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
plugin/src/main/java/com/intellij/java/impl/ide/hierarchy/method/OverrideMethodAction.java Switches action label update to presentation.setText(...).
plugin/src/main/java/com/intellij/java/impl/ide/hierarchy/method/ImplementMethodAction.java Switches action label update to presentation.setText(...).
plugin/src/main/java/com/intellij/java/impl/generate/GenerateToStringAction.java Updates template presentation description to setDescription(...).
plugin/src/main/java/com/intellij/java/impl/codeInspection/inferNullity/InferNullityAnnotationsAction.java Updates progress indicator primary text setter to setText(...).
plugin/src/main/java/com/intellij/java/impl/codeInsight/generation/actions/BaseGenerateAction.java Updates template presentation text setter to setText(...).
plugin/src/main/java/com/intellij/java/impl/analysis/BaseClassesAnalysisAction.java Updates progress indicator primary text setter to setText(...).
java-debugger-impl/src/main/java/com/intellij/java/debugger/impl/engine/JavaDebugProcess.java Updates presentation text toggling to setText(...).
java-debugger-impl/src/main/java/com/intellij/java/debugger/impl/actions/ResumeThreadAction.java Updates presentation text assignment to setText(...).
java-debugger-impl/src/main/java/com/intellij/java/debugger/impl/actions/InterruptThreadAction.java Updates presentation text assignment to setText(...).
java-debugger-impl/src/main/java/com/intellij/java/debugger/impl/actions/EditSourceAction.java Updates presentation text assignment to setText(...).
java-debugger-impl/src/main/java/com/intellij/java/debugger/impl/actions/EditFrameSourceAction.java Updates presentation text assignment to setText(...).
java-compiler-impl/src/main/java/com/intellij/java/compiler/impl/javaCompiler/BackendCompilerWrapper.java Updates progress indicator secondary text setter to setText2(...).
java-compiler-impl/src/main/java/com/intellij/java/compiler/impl/actions/ProcessAnnotationsAction.java Uses setEnabledAndVisible(true) and replaces text updates with setText(...).
java-analysis-impl/src/main/java/com/intellij/java/analysis/impl/find/findUsages/JavaFindUsagesHelper.java Updates progress indicator primary text setter to setText(...).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@VISTALL VISTALL merged commit 0b12fa0 into consulo:master Apr 7, 2026
4 of 5 checks passed
@unv-unv unv-unv deleted the eliminating-set-text-value branch April 7, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants