Localizing GutterIconTooltipHelper#297
Merged
VISTALL merged 1 commit intoconsulo:masterfrom Apr 21, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors GutterIconTooltipHelper to support localization-friendly tooltip construction by switching from MessageFormat/String assembly to LocalizeValue + HtmlBuilder/HtmlChunk composition.
Changes:
- Replaced
MessageFormatpattern strings with aBiFunction<String, String, LocalizeValue>to generate localized tooltip lines. - Changed tooltip composition to build HTML via
HtmlBuilder/HtmlChunkand return anHtmlChunk.Element. - Added
@RequiredReadActionannotations to PSI-reading methods.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+40
to
+47
| @RequiredReadAction | ||
| public static HtmlChunk.Element composeText( | ||
| PsiElement[] elements, | ||
| String startHtml, | ||
| BiFunction<String, String, LocalizeValue> pattern | ||
| ) { | ||
| return composeText(Arrays.asList(elements), startHtml, pattern); | ||
| } |
Comment on lines
+36
to
+46
| public class GutterIconTooltipHelper { | ||
| private GutterIconTooltipHelper() { | ||
| } | ||
|
|
||
| public static String composeText(PsiElement[] elements, String start, String pattern) | ||
| { | ||
| return composeText(Arrays.asList(elements), start, pattern); | ||
| } | ||
| @RequiredReadAction | ||
| public static HtmlChunk.Element composeText( | ||
| PsiElement[] elements, | ||
| String startHtml, | ||
| BiFunction<String, String, LocalizeValue> pattern | ||
| ) { | ||
| return composeText(Arrays.asList(elements), startHtml, pattern); |
Comment on lines
+41
to
+54
| public static HtmlChunk.Element composeText( | ||
| PsiElement[] elements, | ||
| String startHtml, | ||
| BiFunction<String, String, LocalizeValue> pattern | ||
| ) { | ||
| return composeText(Arrays.asList(elements), startHtml, pattern); | ||
| } | ||
|
|
||
| public static String composeText(Iterable<? extends PsiElement> elements, String start, String pattern) | ||
| { | ||
| return composeText(elements, start, pattern, ""); | ||
| } | ||
| @RequiredReadAction | ||
| public static HtmlChunk.Element composeText( | ||
| Iterable<? extends PsiElement> elements, | ||
| String startHtml, | ||
| BiFunction<String, String, LocalizeValue> pattern | ||
| ) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.