Avoid setting tool to already installed if it exited with errors

[rarkins]

Relevant code:

base/src/cli/command/install-tool.ts

Lines 41 to 47 in 1f55081

	} finally {
	logger.info(
	`Installed tool ${this.name} ${
	error ? 'with errors ' : ''
	}in ${prettyMilliseconds(Date.now() - start)}.`
	);
	}

With this example:

install-tool node 10.24.0
install-tool npm 9.5.1
install-tool yarn-slim 1.22.19
install-tool node v18.16.1
install-tool yarn-slim 1.22.19
yarn --version

It should work instead of failed. Today the last install-tool command returns:

$ install-tool yarn-slim 1.22.19
[06:57:14.103] INFO (786): Installing tool yarn-slim v1.22.19...
[06:57:14.152] INFO (786): Preparing legacy tool yarn-slim ...
tool yarn-slim v1.22.19 is already installed

..even though yarn is not installed

[viceice]

with linked PR this will work:

install-tool node 10.24.0
install-tool npm 9.5.1 || true
install-tool yarn-slim 1.22.19
install-tool node v18.16.1
install-tool yarn-slim 1.22.19
yarn --version

[viceice]

• failed tool installation but still considered installed #715