Skip to content

feat(node): allow runtime install#218

Merged
viceice merged 9 commits intomainfrom
feat/dynamic-node
Dec 8, 2021
Merged

feat(node): allow runtime install#218
viceice merged 9 commits intomainfrom
feat/dynamic-node

Conversation

@viceice
Copy link
Member

@viceice viceice commented Dec 7, 2021

@viceice viceice requested a review from rarkins December 7, 2021 17:35
@rarkins
Copy link
Contributor

rarkins commented Dec 7, 2021

Do we need to purge any node installs (e.g. npm, pnpm, yarn) if we change node version?

@viceice
Copy link
Member Author

viceice commented Dec 7, 2021

Do we need to purge any node installs (e.g. npm, pnpm, yarn) if we change node version?

I don't think so. Why should we need to purge?

@rarkins
Copy link
Contributor

rarkins commented Dec 7, 2021

Might any of them build/install differently based on the version of node? I guess I'm thinking about re2 and similar

@viceice
Copy link
Member Author

viceice commented Dec 7, 2021

I've never seen that behavior on package managers, but i can add some more tests to verify

@viceice viceice marked this pull request as draft December 7, 2021 19:04
@rarkins
Copy link
Contributor

rarkins commented Dec 7, 2021

We'd need it later for Eg new python means purging any pop or poetry?

@viceice
Copy link
Member Author

viceice commented Dec 8, 2021

Maybe, let's defer it, until we have something to test against.

@viceice viceice marked this pull request as ready for review December 8, 2021 09:58
@viceice viceice merged commit 48c5719 into main Dec 8, 2021
@viceice viceice deleted the feat/dynamic-node branch December 8, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node: runtime install

2 participants