Skip to content

fix: shell wrapper has 775 permissions for overwrites #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
viceice merged 3 commits into from
Mar 17, 2022
Merged

fix: shell wrapper has 775 permissions for overwrites #341

viceice merged 3 commits into from
Mar 17, 2022

Conversation

@Chumper
Copy link
Contributor

@Chumper Chumper commented Mar 16, 2022

  • Sets the correct path for shell wrappers
  • Adds test for the shell wrapper
  • sets the permissions to 775 for the shell wrappers

Closes #338

@Chumper Chumper requested a review from viceice March 16, 2022 23:10
viceice
viceice reviewed Mar 17, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@viceice viceice enabled auto-merge (squash) March 17, 2022 08:50
@viceice viceice merged commit 5e9c888 into containerbase:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viceice viceice viceice left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

User installs should be able to overwrite tool symlinks created by root installs

2 participants

@Chumper @viceice