Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
example/example
cmd/cgctl
141 changes: 141 additions & 0 deletions cmd/cgctl/main.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,141 @@
/*
Copyright The containerd Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package main

import (
"fmt"
"os"

v2 "github.com/containerd/cgroups/v2"
"github.com/sirupsen/logrus"
"github.com/urfave/cli"
)

func main() {
app := cli.NewApp()
app.Name = "cgctl"
app.Version = "1"
app.Usage = "cgroup v2 management tool"
app.Flags = []cli.Flag{
cli.BoolFlag{
Name: "debug",
Usage: "enable debug output in the logs",
},
cli.StringFlag{
Name: "mountpoint",
Usage: "cgroup mountpoint",
Value: "/sys/fs/cgroup",
},
}
app.Commands = []cli.Command{
newCommand,
delCommand,
listCommand,
statCommand,
}
app.Before = func(clix *cli.Context) error {
if clix.GlobalBool("debug") {
logrus.SetLevel(logrus.DebugLevel)
}
return nil
}
if err := app.Run(os.Args); err != nil {
fmt.Fprintln(os.Stderr, err)
os.Exit(1)
}
}

var newCommand = cli.Command{
Name: "new",
Usage: "create a new cgroup",
Flags: []cli.Flag{
cli.BoolFlag{
Name: "enable",
Usage: "enable the controllers for the group",
},
},
Action: func(clix *cli.Context) error {
path := clix.Args().First()
c, err := v2.NewManager(clix.GlobalString("mountpoint"), path, nil)
if err != nil {
return err
}
if clix.Bool("enable") {
controllers, err := c.ListControllers()
if err != nil {
return err
}
if err := c.ToggleControllers(controllers, v2.Enable); err != nil {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be done for the parent group?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to enable this at all if the system is setup to enable them

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you have cpu in the top group /sys/fs/cgroup, cpu is enabled for /sys/fs/cgroup/foo, but not enabled for /sys/fs/cgroup/foo/bar.

root@suda-ws01:/sys/fs/cgroup# cat cgroup.controllers 
cpuset cpu io memory pids rdma
root@suda-ws01:/sys/fs/cgroup# mkdir foo
root@suda-ws01:/sys/fs/cgroup# cat foo/cgroup.controllers 
cpu io memory pids
root@suda-ws01:/sys/fs/cgroup# mkdir foo/bar
root@suda-ws01:/sys/fs/cgroup# cat foo/bar/cgroup.controllers 
root@suda-ws01:/sys/fs/cgroup#

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, its up to the creator of the cgroup to enable these. I don't think the sub cgroup should modify the parent settings

return err
}
}
return nil
},
}

var delCommand = cli.Command{
Name: "del",
Usage: "delete a cgroup",
Action: func(clix *cli.Context) error {
path := clix.Args().First()
c, err := v2.LoadManager(clix.GlobalString("mountpoint"), path)
if err != nil {
return err
}
return c.Delete()
},
}

var listCommand = cli.Command{
Name: "list",
Usage: "list processes in a cgroup",
Action: func(clix *cli.Context) error {
path := clix.Args().First()
c, err := v2.LoadManager(clix.GlobalString("mountpoint"), path)
if err != nil {
return err
}
procs, err := c.Procs(true)
if err != nil {
return err
}
for _, p := range procs {
fmt.Println(p)
}
return nil
},
}

var statCommand = cli.Command{
Name: "stat",
Usage: "stat a cgroup",
Action: func(clix *cli.Context) error {
path := clix.Args().First()
c, err := v2.LoadManager(clix.GlobalString("mountpoint"), path)
if err != nil {
return err
}
stats, err := c.Stat()
if err != nil {
return err
}
for k, v := range stats {
fmt.Printf("%s->%d\n", k, v)
}
return nil
},
}
117 changes: 0 additions & 117 deletions cmd/cgroups-playground/main.go

This file was deleted.

Loading