fs: add TestCopyReflinkWithXFS#128
Merged
estesp merged 1 commit intocontainerd:masterfrom Oct 3, 2018
Merged
Conversation
AkihiroSuda
force-pushed
the
test-reflink
branch
from
38b1af3 to
1b29657
Compare
dmcgowan
reviewed
Sep 19, 2018
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| if _, err := io.CopyN(a, rand.Reader, aSize); err != nil { |
Member
There was a problem hiding this comment.
Don't use crypto rand for this
Member
Author
There was a problem hiding this comment.
What should I do instead?
Member
There was a problem hiding this comment.
math/rand should work just fine here and be much faster
dmcgowan
reviewed
Sep 19, 2018
AkihiroSuda
force-pushed
the
test-reflink
branch
from
1b29657 to
8af0fb6
Compare
Member
Author
|
updated |
dmcgowan
reviewed
Oct 2, 2018
| @@ -0,0 +1,81 @@ | |||
| // +build linux | |||
Member
There was a problem hiding this comment.
The file header checking was added, that needs to be added here to pass CI
Member
|
LGTM after header added to make CI hapy |
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
AkihiroSuda
force-pushed
the
test-reflink
branch
from
8af0fb6 to
8568d91
Compare
Member
Author
|
updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure
CopyFile()supports reflink on XFS.This PR also covers #127