Switch from x/net/context to context#133
Merged
estesp merged 2 commits intocontainerd:masterfrom Sep 18, 2018
Merged
Conversation
Since go 1.7, "context" is a standard package. Since go 1.9, x/net/context merelyprovides some types aliased to those in the standard context package, so there is no functional change. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Go 1.8 is unsupported since Go 1.10 was released in Feb 2018. In fact, Go 1.9 is also unsupported (since Go 1.11 was released in 24 August 2018), but let it stay for now. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
Author
|
Also remove go 1.8 from travis.yaml. Alas, this is no longer the post trivial PR 😿 |
Member
My PR is more trivial (waiting for review ^^) #127 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since go 1.7, "context" is a standard package. Since go 1.9,
x/net/context merelyprovides some types aliased to those in the
standard context package, so there is no functional change.
PS is there any "the most trivial PR of the year" contest? I'd like to nominate this one please.