Skip to content

[breaking change] proto: uid, gid: string -> int64 #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stevvooe merged 1 commit into from
May 25, 2017
Merged

[breaking change] proto: uid, gid: string -> int64 #77

stevvooe merged 1 commit into from
May 25, 2017

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented May 25, 2017

@AkihiroSuda
proto: uid, gid: string -> int64
385e364 
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
@AkihiroSuda AkihiroSuda mentioned this pull request May 25, 2017
Merged
@dmcgowan
Copy link
Member

dmcgowan commented May 25, 2017

+1
We have discussed doing this for awhile as having usernames is never desired and we discovered having it be a string has no benefit for windows.

@stevvooe
Copy link
Member

stevvooe commented May 25, 2017

LGTM

This is breaking.

@stevvooe stevvooe merged commit 04e8856 into containerd:master May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AkihiroSuda @dmcgowan @stevvooe