ignore image_pull.go SA1019 tlsConfig.BuildNameToCertificate is deprecated

[mikebrow]

Resolves:

Got an error that seems unrelated to my changes:

I0624 07:55:20.688] pkg/server/image_pull.go:287:3: SA1019: tlsConfig.BuildNameToCertificate is deprecated: NameToCertificate only allows associating a single certificate with a given name. Leave that field nil to let the library select the first compatible chain from Certificates.  (staticcheck)
I0624 07:55:20.688] 		tlsConfig.BuildNameToCertificate()
I0624 07:55:20.688] 		^

let's see... BuildNameToCertificate seems to have been deprecated in go 1.14.. and must've been cherry picked in the linter we are using so..

Signed-off-by: Mike Brown brownwm@us.ibm.com

[mikebrow]

/test pull-cri-containerd-node-e2e

[thaJeztah]

Curious; Is there an alternative that would work without ignoring?

[k8s-ci-robot]

@mikebrow: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-cri-containerd-node-e2e	a128d10	link	/test pull-cri-containerd-node-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[mikebrow]

Curious; Is there an alternative that would work without ignoring?

Nothing that I found. Field NameToCertificate set by BuildNameToCertificate() was deprecated without replacement.

// NameToCertificate maps from a certificate name to an element of
// Certificates. Note that a certificate name can be of the form
// '*.example.com' and so doesn't have to be a domain name as such.
//
// Deprecated: NameToCertificate only allows associating a single
// certificate with a given name. Leave this field nil to let the library
// select the first compatible chain from Certificates.
NameToCertificate map[string]*Certificate

IOW it only remembers one name to certificate in the NameToCertificate map.. if you have two.. you get the last one..

seems to be saying... don't call Build.. leave the map nil... and as long as you don't use the map.. the library will do what is needed to pick certificate from certificates...

[thaJeztah]

ugh. I hate deprecated without clear replacement. not at my keyboard, but will have a look if the commit history provides more context

…

On 24 Jun 2020, at 23:36, Mike Brown ***@***.***> wrote:  Curious; Is there an alternative that would work without ignoring? Nothing that I found. Field NameToCertificate set by BuildNameToCertificate() was deprecated without replacement. // NameToCertificate maps from a certificate name to an element of // Certificates. Note that a certificate name can be of the form // '*.example.com' and so doesn't have to be a domain name as such. // // Deprecated: NameToCertificate only allows associating a single // certificate with a given name. Leave this field nil to let the library // select the first compatible chain from Certificates. NameToCertificate map[string]*Certificate IOW it only remembers one name to certificate in the NameToCertificate map.. if you have two.. you get the last one.. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[thaJeztah]

LGTM

[mikebrow]

ugh. I hate deprecated without clear replacement. not at my keyboard, but will have a look if the commit history provides more context
…

yeah have looked through the code.. now. If you don't set NameToCertificate... the library will just loop through all certificates looking for a match, vs doing the match based on the one you set in BuildNameToCertificate()

Not sure that is better or worse and would be a behavior change.

[mikebrow]

Not sure what broke the k8s e2e bucket.. sigh :-)

[mikebrow]

ok fix for node e2e bucket here:
#1517

[mikebrow]

will just merge this over to the e2e bucket fix yeah I know could've done that here... long day