Skip to content

exclude default bridge network in network prune#1304

Merged
AkihiroSuda merged 1 commit into
containerd:masterfrom
tal66:dont-prune-bridge
Aug 13, 2022
Merged

exclude default bridge network in network prune#1304
AkihiroSuda merged 1 commit into
containerd:masterfrom
tal66:dont-prune-bridge

Conversation

@tal66
Copy link
Copy Markdown
Contributor

@tal66 tal66 commented Aug 8, 2022

Hi, this should fix #1295
(nerdctl network prune does not need to remove the default bridge network)

Comment thread cmd/nerdctl/network_prune.go Outdated
@manugupt1
Copy link
Copy Markdown
Contributor

Please sign off with real name.

@fahedouch
Copy link
Copy Markdown
Member

fahedouch commented Aug 9, 2022

plz use DefaultNetworkDriver const from package main so we avoid deleting bridge for unix and nat for windows
see #1279 (comment)

@junnplus junnplus added the status/needs-DCO-sign Needs DCO sign (the “Signed-off-by” in the commit message) label Aug 10, 2022
Comment thread cmd/nerdctl/network_prune.go Outdated
Comment thread cmd/nerdctl/network_prune.go Outdated
@fahedouch
Copy link
Copy Markdown
Member

Thanks, but please squash your commits and sign the commit for DCO
https://github.com/apps/dco

(run git commit -a -s --amend, and make sure that the Signed-off-by: NAME <EMAIL> line with your real name is included in the commit message)

Comment thread cmd/nerdctl/network_prune.go Outdated
Signed-off-by: tal mika <77445020+tal66@users.noreply.github.com>
@AkihiroSuda AkihiroSuda removed the status/needs-DCO-sign Needs DCO sign (the “Signed-off-by” in the commit message) label Aug 13, 2022
@AkihiroSuda AkihiroSuda added this to the v0.22.3 milestone Aug 13, 2022
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nerdctl network prune does not need to remove the default bridge network

5 participants