Dockerfile: verify fetched binaries#147
Merged
AkihiroSuda merged 2 commits intocontainerd:masterfrom Apr 1, 2021
Merged
Conversation
mirror.gcr.io seems unstable, so Docker Hub seems still better, though it has tight rate limits at least on macOS instances as far as we know. Workaround for containerd#146 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
verify-sha256sums
branch
from
2827b22 to
f064c42
Compare
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
verify-sha256sums
branch
from
f064c42 to
bb3b8e4
Compare
ktock
approved these changes
Apr 1, 2021
Member
ktock
left a comment
ktock
left a comment
There was a problem hiding this comment.
LGTM
For making the contribution easier, we'll want helper scripts something like this ( https://github.com/kubernetes-sigs/kind/blob/8fe8b962521db017e3ffb22fc410f521dd8bc154/images/base/update-shasums.sh )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify the binaries to detect compromised ones.
This PR also switches back from
mirror.gcr.ioto Docker Hub to make CI green (#146)