Skip to content

[Refactor]: Move fmtutil from cmd to pkg/formatter#1779

Merged
AkihiroSuda merged 1 commit into
containerd:mainfrom
Zheaoli:manjusaka/split-fmtutil
Dec 30, 2022
Merged

[Refactor]: Move fmtutil from cmd to pkg/formatter#1779
AkihiroSuda merged 1 commit into
containerd:mainfrom
Zheaoli:manjusaka/split-fmtutil

Conversation

@Zheaoli
Copy link
Copy Markdown
Member

@Zheaoli Zheaoli commented Dec 29, 2022

Signed-off-by: Zheao.Li me@manjusaka.me

@Zheaoli Zheaoli force-pushed the manjusaka/split-fmtutil branch from 71e8108 to fb4f905 Compare December 29, 2022 04:00
@Zheaoli Zheaoli mentioned this pull request Dec 29, 2022
Merged
2 tasks
@AkihiroSuda AkihiroSuda added this to the v1.2.0 milestone Dec 29, 2022
AkihiroSuda
AkihiroSuda previously approved these changes Dec 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

AkihiroSuda
AkihiroSuda reviewed Dec 29, 2022
View reviewed changes
Comment thread pkg/fmtutil/fmtutil.go Outdated
@Zheaoli Zheaoli force-pushed the manjusaka/split-fmtutil branch from fb4f905 to 594192e Compare December 29, 2022 04:12
@djdongjin
Copy link
Copy Markdown
Member

djdongjin commented Dec 29, 2022

Should we combine this pkg/fmtutil with pkg/formatter package? From the name they are quite similar.

https://github.com/containerd/nerdctl/blob/49aa8fbddeae6f92deaec08178673a9e7c55f661/pkg/formatter/

@Zheaoli Zheaoli force-pushed the manjusaka/split-fmtutil branch from 594192e to b9c000d Compare December 29, 2022 05:17
djdongjin
djdongjin approved these changes Dec 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@djdongjin djdongjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zheaoli Zheaoli mentioned this pull request Dec 29, 2022
Merged
@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Dec 29, 2022 •
edited
Loading

(Commit message and PR title)

pkg/fmtutil

pkg/formatter

fahedouch
fahedouch approved these changes Dec 30, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@fahedouch fahedouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Zheaoli Zheaoli force-pushed the manjusaka/split-fmtutil branch from b9c000d to 72ea92a Compare December 30, 2022 11:17
@Zheaoli Zheaoli changed the title [Refactor]: Move fmtutil from cmd to pkg/fmtutil [Refactor]: Move fmtutil from cmd to pkg/formatter Dec 30, 2022
@Zheaoli
[Refactor]: Move fmtutil from cmd to pkg/formatter
52b2fa0 
Signed-off-by: Zheao.Li <me@manjusaka.me>
@Zheaoli Zheaoli force-pushed the manjusaka/split-fmtutil branch from 72ea92a to 52b2fa0 Compare December 30, 2022 11:20
AkihiroSuda
AkihiroSuda approved these changes Dec 30, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 8c991c2 into containerd:main Dec 30, 2022
@Zheaoli Zheaoli deleted the manjusaka/split-fmtutil branch December 30, 2022 13:14
@Zheaoli Zheaoli mentioned this pull request Dec 31, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@fahedouch fahedouch fahedouch approved these changes

@djdongjin djdongjin djdongjin approved these changes

Assignees

No one assigned

Labels

kind/refactor

Projects

None yet

Milestone

v1.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Zheaoli @djdongjin @AkihiroSuda @fahedouch