[Refactor] Move the Config Struct from cmd/main.go to pkg/config#1793
Merged
AkihiroSuda merged 1 commit intoJan 2, 2023
Merged
Conversation
AkihiroSuda
reviewed
Jan 2, 2023
Zheaoli
force-pushed
the
manjusaka/refactor-global-config
branch
from
b80bc98 to
5f29e1a
Compare
Zheaoli
changed the title
AkihiroSuda
reviewed
Jan 2, 2023
Zheaoli
force-pushed
the
manjusaka/refactor-global-config
branch
from
5f29e1a to
a3478f8
Compare
AkihiroSuda
reviewed
Jan 2, 2023
Signed-off-by: Zheao.Li <me@manjusaka.me>
Zheaoli
force-pushed
the
manjusaka/refactor-global-config
branch
from
a3478f8 to
30b09eb
Compare
2 tasks
fahedouch
reviewed
Jan 7, 2023
|
|
||
| func initRootCmdFlags(rootCmd *cobra.Command, tomlPath string) (*pflag.FlagSet, error) { | ||
| cfg := NewConfig() | ||
| cfg := config.New() |
Member
There was a problem hiding this comment.
Is it better to init GlobalCommandOptions here and then pass it to config.New()
cfg := GlobalCommandOptions{...}
config.New(cfg)
to keep the code semantic.
Cc @Zheaoli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the subcommand is related to this Config struct and global flags. like #1792
So I split it from the cmd package to let us can reuse the definition.
Signed-off-by: Zheao.Li me@manjusaka.me