[Refactor] Refactor the load command flagging process#1820
Merged
Conversation
Signed-off-by: Zheao.Li <me@manjusaka.me>
Zheaoli
force-pushed
the
manjusaka/refactor-load
branch
from
a903585 to
efaf3d6
Compare
djdongjin
reviewed
Jan 9, 2023
|
|
||
| return loadImage(decompressor, cmd, globalOptions, platMC, false) | ||
| return types.LoadCommandOptions{ | ||
| GOptions: *globalOptions, |
Member
There was a problem hiding this comment.
no change required here, but we might gradually change the pointer usage of global option to non-pointer to avoid unintented shared memory among goroutines (#1795 (comment)) and also be consistent with other command option usages.
- Those global options in function signatures should be fine, as they should be gradually replaced by individual command options (with global option being a field).
processRootCmdFlagsshould be changed to return a struct not a struct pointer. Similarly, SubCommandOptions should hold a global option struct (as inLoadCommandOptions) not a struct pointer.
I guess the original intent of using global option as a pointer is to avoid unnecessary copies, but I think it should be fine as those option structs are quite small, and also pointers use heap allocation which means more GC work.
Member
Author
There was a problem hiding this comment.
I will make a split PR to update it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
pkg/api/types/${cmd}_types.go, and define the CommandOption for this commandpkg/cmd/${cmd}, and move the command entry point in real into this packageSigned-off-by: Zheao.Li me@manjusaka.me