Skip to content

[DNM] bisect BuildKit (0.11.0-rc1, rc2, ...)#1833

Closed
AkihiroSuda wants to merge 10 commits intocontainerd:mainfrom
AkihiroSuda:buildkit-0.11-rc.1
Closed

[DNM] bisect BuildKit (0.11.0-rc1, rc2, ...)#1833
AkihiroSuda wants to merge 10 commits intocontainerd:mainfrom
AkihiroSuda:buildkit-0.11-rc.1

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda commented Jan 12, 2023

  • ✅ v0.11.0-rc1
  • ✅ v0.11.0-rc1-63-g0e1e7d6e
  • ✅ v0.11.0-rc1-80-g6b004d35
  • ✅ v0.11.0-rc1-84-gc0ac5e8b
  • ✅ v0.11.0-rc1-87-g179bed6b
  • v0.11.0-rc1-88-ge5f99592 build history: support for image descriptors
  • ❌ v0.11.0-rc1-89-g926451ee
  • ❌ v0.11.0-rc1-90-gab0d1a6e
  • ❌ v0.11.0-rc1-96-ged041ab3
  • ❌ v0.11.0-rc2

=== Failed
=== FAIL: cmd/nerdctl TestImageEncryptJWE (2.70s)
    testregistry_linux.go:49: hostIP="10.4.0.1", listenIP="0.0.0.0", listenPort=5000
    image_encrypt_linux_test.go:90: assertion failed: res.ExitCode is 0

=== FAIL: cmd/nerdctl TestIPFSComposeUpBuild (1.81s)
    testutil.go:510: buildkitHost="unix:///run/buildkit-nerdctl-test/buildkitd.sock"
    ipfs_linux_test.go:159: assertion failed: 0 (int) != 1 (res.ExitCode int): time="2023-01-12T03:19:54Z" level=info msg="pushing image \"ghcr.io/stargz-containers/nginx:1.19-alpine-org\" to IPFS"
        time="2023-01-12T03:19:54Z" level=info msg="ensuring image contents"
        time="2023-01-12T03:19:54Z" level=warning msg="failed to ensure the existence of image \"ghcr.io/stargz-containers/nginx:1.19-alpine-org\"" error="no CID is recorded"
        time="2023-01-12T03:19:54Z" level=warning msg="ipfs push failed" error="content digest sha256:de48f30650ccde3e8186cc4c7634cab55ab8c031cc108e34a91b20a8f1deec1b: not found"
        time="2023-01-12T03:19:54Z" level=fatal msg="content digest sha256:de48f30650ccde3e8186cc4c7634cab55ab8c031cc108e34a91b20a8f1deec1b: not found"
        

=== FAIL: cmd/nerdctl TestImageEncryptJWE (re-run 1) (4.27s)
    testregistry_linux.go:49: hostIP="10.4.0.1", listenIP="0.0.0.0", listenPort=5000
    image_encrypt_linux_test.go:90: assertion failed: res.ExitCode is 0

=== FAIL: cmd/nerdctl TestImageEncryptJWE (re-run 2) (2.87s)
    testregistry_linux.go:49: hostIP="10.4.0.1", listenIP="0.0.0.0", listenPort=5000
    image_encrypt_linux_test.go:90: assertion failed: res.ExitCode is 0

DONE 3 runs, 400 tests, 8 skipped, 4 failures in 976.404s

https://github.com/containerd/nerdctl/actions/runs/3898739937/jobs/6657762795

func TestImageEncryptJWE(t *testing.T) {
testutil.DockerIncompatible(t)
keyPair := newJWEKeyPair(t)
defer keyPair.cleanup()
base := testutil.NewBase(t)
tID := testutil.Identifier(t)
reg := testregistry.NewPlainHTTP(base, 5000)
defer reg.Cleanup()
base.Cmd("pull", testutil.CommonImage).AssertOK()
encryptImageRef := fmt.Sprintf("127.0.0.1:%d/%s:encrypted", reg.ListenPort, tID)
defer base.Cmd("rmi", encryptImageRef).Run()
base.Cmd("image", "encrypt", "--recipient=jwe:"+keyPair.pub, testutil.CommonImage, encryptImageRef).AssertOK()
base.Cmd("image", "inspect", "--mode=native", "--format={{len .Index.Manifests}}", encryptImageRef).AssertOutExactly("1\n")
base.Cmd("image", "inspect", "--mode=native", "--format={{json .Manifest.Layers}}", encryptImageRef).AssertOutContains("org.opencontainers.image.enc.keys.jwe")
base.Cmd("push", encryptImageRef).AssertOK()
// remove all local images (in the nerdctl-test namespace), to ensure that we do not have blobs of the original image.
rmiAll(base)
base.Cmd("pull", encryptImageRef).AssertFail() // defaults to --unpack=true, and fails due to missing prv key

  • ❌ v0.11.0

Seems a regression in moby/buildkit@e5f99592

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda changed the title [DNM] update BuildKit (0.11.0-rc.1) [DNM] update BuildKit (0.11.0-rc1, rc2, ...) Jan 12, 2023
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda changed the title [DNM] update BuildKit (0.11.0-rc1, rc2, ...) [DNM] bisect BuildKit (0.11.0-rc1, rc2, ...) Jan 12, 2023
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant