[Refactor] Move exit_coder from cmd to pkg/errutil#1857
Merged
Conversation
Contributor
Author
AkihiroSuda
reviewed
Jan 17, 2023
Signed-off-by: Laitron <meetlq@outlook.com>
aeee957 to
efb501c
Compare
This was referenced Jan 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
ExitCodeErrorfromcmdtopkg/exitcoderpkg/errutilnerdctl/cmd/nerdctl/start.go
Lines 187 to 190 in 0b051a5
When I refactor the container start command, I have discovered that
ExitCodeErrorfromcmdis blocking my work.nerdctl/cmd/nerdctl/main.go
Lines 343 to 367 in 0b051a5
Maybe we should refactor
ExitCodeErrorfirst, by moving it topkg/exitcoder. Then we can continue with our other tasks.Signed-off-by: Laitron meetlq@outlook.com