Skip to content

[Refactor] refactor rmi flagging process#1892

Merged
AkihiroSuda merged 1 commit into
containerd:mainfrom
suyanhanx:refactor-image-rm-flag
Jan 23, 2023
Merged

[Refactor] refactor rmi flagging process#1892
AkihiroSuda merged 1 commit into
containerd:mainfrom
suyanhanx:refactor-image-rm-flag

Conversation

@suyanhanx
Copy link
Copy Markdown
Contributor

part of #1680

Checklist:

  • Create a file in pkg/api/types/${cmd}_types.go, and define the CommandOption for this command
  • Create some file in pkg/cmd/${cmd}, and move the command entry point in real into this package

Signed-off-by: suyanhanx suyanhanx@gmail.com

Comment thread pkg/api/types/rmi_types.go Outdated
@suyanhanx suyanhanx force-pushed the refactor-image-rm-flag branch from b37127a to 8d346bd Compare January 21, 2023 02:20
Comment thread pkg/api/types/image_types.go Outdated
Comment thread pkg/cmd/image/remove.go Outdated
@suyanhanx suyanhanx force-pushed the refactor-image-rm-flag branch from 8d346bd to 85b5180 Compare January 22, 2023 12:03
@suyanhanx suyanhanx requested a review from djdongjin January 22, 2023 12:04
@suyanhanx suyanhanx force-pushed the refactor-image-rm-flag branch from 85b5180 to e2e10ad Compare January 22, 2023 12:05
Comment thread cmd/nerdctl/rmi.go Outdated
Comment thread cmd/nerdctl/rmi.go Outdated
@suyanhanx suyanhanx force-pushed the refactor-image-rm-flag branch from e2e10ad to 8e7a56a Compare January 23, 2023 06:17
@AkihiroSuda AkihiroSuda added this to the v1.2.0 milestone Jan 23, 2023
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx force-pushed the refactor-image-rm-flag branch from 8e7a56a to 85d2283 Compare January 23, 2023 06:37
@suyanhanx suyanhanx requested a review from djdongjin January 23, 2023 07:35
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 7abc7fa into containerd:main Jan 23, 2023
@suyanhanx suyanhanx deleted the refactor-image-rm-flag branch January 23, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants