refactor: move stopContainer to containerutil#1897
Merged
Conversation
djdongjin
reviewed
Jan 21, 2023
| return nil | ||
| } | ||
|
|
||
| func Stop(ctx context.Context, container containerd.Container, timeout *time.Duration) error { |
Member
There was a problem hiding this comment.
Can you add some comments here, something like
// Stop stops `container` by sending SIGTERM. If the container is not stopped after `timeout`, it sends a SIGKILL.
Contributor
Author
There was a problem hiding this comment.
Good point, thanks. Updated.
davidhsingyuchen
force-pushed
the
move-stopContainer
branch
from
8f6b084 to
eb62918
Compare
Member
|
Needs rebase |
Signed-off-by: Hsing-Yu (David) Chen <davidhsingyuchen@gmail.com>
davidhsingyuchen
force-pushed
the
move-stopContainer
branch
from
eb62918 to
a09ce88
Compare
AkihiroSuda
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR is a blocker of #1896. Also removed
Containerfrom the function name due to the same rationale stated in the description of #1890.Signed-off-by: Hsing-Yu (David) Chen davidhsingyuchen@gmail.com