[Refactor] Reorder the method argument ordering in pkg/cmd#1900
Merged
Conversation
Zheaoli
force-pushed
the
manjusaka/reorder-argument
branch
2 times, most recently
from
26318f7 to
b1c92d9
Compare
2 tasks
Zheaoli
force-pushed
the
manjusaka/reorder-argument
branch
from
b1c92d9 to
5604394
Compare
Zheaoli
force-pushed
the
manjusaka/reorder-argument
branch
5 times, most recently
from
9614b41 to
476e2bd
Compare
djdongjin
requested changes
Jan 22, 2023
Member
djdongjin
left a comment
djdongjin
left a comment
There was a problem hiding this comment.
Changes in pkg/* packages (except pkg/api and pkg/cmd) seems unexpected. Can you revert these changes?
Zheaoli
force-pushed
the
manjusaka/reorder-argument
branch
3 times, most recently
from
c2e57b0 to
b465406
Compare
djdongjin
approved these changes
Jan 22, 2023
Member
djdongjin
left a comment
djdongjin
left a comment
There was a problem hiding this comment.
LGTM aside from 2 minor changes, thanks
AkihiroSuda
reviewed
Jan 22, 2023
AkihiroSuda
reviewed
Jan 22, 2023
AkihiroSuda
reviewed
Jan 22, 2023
AkihiroSuda
reviewed
Jan 22, 2023
AkihiroSuda
reviewed
Jan 22, 2023
AkihiroSuda
reviewed
Jan 22, 2023
AkihiroSuda
reviewed
Jan 22, 2023
Zheaoli
force-pushed
the
manjusaka/reorder-argument
branch
from
b465406 to
9003cf2
Compare
Signed-off-by: Zheao.Li <me@manjusaka.me>
Zheaoli
force-pushed
the
manjusaka/reorder-argument
branch
from
9003cf2 to
1316fd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1889
Signed-off-by: Zheao.Li me@manjusaka.me