Skip to content

Deflake TestRunCustomRootfs by workaround#2367

Closed
yankay wants to merge 1 commit intocontainerd:mainfrom
yankay:workaround-for-issue-2327
Closed

Deflake TestRunCustomRootfs by workaround#2367
yankay wants to merge 1 commit intocontainerd:mainfrom
yankay:workaround-for-issue-2327

Conversation

@yankay
Copy link
Copy Markdown
Contributor

@yankay yankay commented Jul 10, 2023

Attempt to fix #2327 by workaround

The failure is because the nerdctl can not pull all the layers,
and the ctr can do it.

Signed-off-by: Kay Yan <kay.yan@daocloud.io>
@fahedouch
Copy link
Copy Markdown
Member

Thanks, but I don't think that is a good idea to add a dependency to ctr . IMHO we have to investigate why nerdctl do not attempt to fetch correctly layers inside the ci

@fahedouch fahedouch added area/ci e.g., CI failure status/needs-more-information Needs more information from OP labels Jul 10, 2023
@yankay
Copy link
Copy Markdown
Contributor Author

yankay commented Jul 11, 2023

Thanks @fahedouch

After investigating the issue, the root cause is here:
https://github.com/containerd/containerd/blob/main/pkg/unpack/unpacker.go#L300C14-L300C14
The layer is skipped because the snapshot can be found.

But I have no idea how to fix it now :-)

@fahedouch
Copy link
Copy Markdown
Member

Thanks @fahedouch

After investigating the issue, the root cause is here: https://github.com/containerd/containerd/blob/main/pkg/unpack/unpacker.go#L300C14-L300C14 The layer is skipped because the snapshot can be found.

But I have no idea how to fix it now :-)

So it is no longer a cli issue.

@apostasie
Copy link
Copy Markdown
Contributor

A workaround has been put in place in #3179 that seems to address the issue on the CI.

As for the underlying issue, 2 cents is on the fact we do not ensure the image is extracted (will look into that lead later).

@apostasie
Copy link
Copy Markdown
Contributor

@AkihiroSuda I guess this can be closed?

@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda I guess this can be closed?

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci e.g., CI failure status/needs-more-information Needs more information from OP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flaky test: content digest sha256:xxx: not found in CI

4 participants