Skip to content

Add repository login component username validation#3166

Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom
Shikachuu:fix-login-username
Jul 14, 2024
Merged

Add repository login component username validation#3166
AkihiroSuda merged 1 commit intocontainerd:mainfrom
Shikachuu:fix-login-username

Conversation

@Shikachuu
Copy link
Copy Markdown
Contributor

Validate username in login.go command

Fixes #3069

@apostasie
Copy link
Copy Markdown
Contributor

Thanks @Shikachuu !

Left a couple of comments.
Looks to me like the CI failure is unrelated, but let's see.

@Shikachuu
Copy link
Copy Markdown
Contributor Author

Thanks @Shikachuu !

Left a couple of comments. Looks to me like the CI failure is unrelated, but let's see.

Ngl I don't see any comments but this one, where should I find those?

Checked the CI too, at first glance it doesn't seem login related.

Comment thread cmd/nerdctl/login.go Outdated
Comment thread cmd/nerdctl/login.go Outdated
@apostasie
Copy link
Copy Markdown
Contributor

Thanks @Shikachuu !
Left a couple of comments. Looks to me like the CI failure is unrelated, but let's see.

Ngl I don't see any comments but this one, where should I find those?

Checked the CI too, at first glance it doesn't seem login related.

My bad - forgot to press the big green button to send these comments :p

You should see them now.

@apostasie
Copy link
Copy Markdown
Contributor

@Shikachuu can you rebase on the latest main? There has been some kerfuffle earlier on project checks (my fault). Hopefully rebasing should fix it.

@Shikachuu
Copy link
Copy Markdown
Contributor Author

@Shikachuu can you rebase on the latest main? There has been some kerfuffle earlier on project checks (my fault). Hopefully rebasing should fix it.

✔️ done, hopefully fixes it!

@fahedouch fahedouch added this to the v2.0.0 milestone Jul 6, 2024
@fahedouch fahedouch added the area/login authentification/ login label Jul 6, 2024
Comment thread cmd/nerdctl/login.go Outdated
@apostasie
Copy link
Copy Markdown
Contributor

@Shikachuu can you rebase on the latest main? There has been some kerfuffle earlier on project checks (my fault). Hopefully rebasing should fix it.

✔️ done, hopefully fixes it!

It does.
Thanks a lot @Shikachuu !

LGTM as far as I am concerned (I am not a maintainer here, so, this is not formal approval).

Comment thread cmd/nerdctl/login.go Outdated
Signed-off-by: Czékus Máté <mate@picloud.hu>
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit d9a9a83 into containerd:main Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/login authentification/ login

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nerdctl login allows passing a username with a colon, which is forbidden by RFC 7617

4 participants