Skip to content

[WIP] Login rework#3249

Closed
apostasie wants to merge 1 commit intocontainerd:mainfrom
apostasie:dev-login
Closed

[WIP] Login rework#3249
apostasie wants to merge 1 commit intocontainerd:mainfrom
apostasie:dev-login

Conversation

@apostasie
Copy link
Copy Markdown
Contributor

@apostasie apostasie commented Jul 25, 2024

WORK IN PROGRESS

Fixed:

Other changes:

  • nerdctl now returns a user-agent string with version and OS
  • removing IsErrHTTPResponseToHTTPSClient, as http.ErrSchemeMismatch is usable in place
  • new errors

TODO:

To be confirmed:

Currently NOT addressed:

@apostasie apostasie force-pushed the dev-login branch 19 times, most recently from c3b28de to 1799b12 Compare August 1, 2024 18:10
@apostasie apostasie force-pushed the dev-login branch 5 times, most recently from 87fce1f to 6e9c154 Compare August 7, 2024 06:36
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie
Copy link
Copy Markdown
Contributor Author

@AkihiroSuda I am closing this as I am breaking it down and distilling it into smaller, separate PRs to ease review. Will keep the branch as long as there are things to merge, but otherwise there is no reason to keep this open.

@apostasie apostasie closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment