Skip to content

Post containerd v2 cleanup#3288

Merged
AkihiroSuda merged 3 commits intocontainerd:mainfrom
apostasie:dev-ctd2-post
Aug 10, 2024
Merged

Post containerd v2 cleanup#3288
AkihiroSuda merged 3 commits intocontainerd:mainfrom
apostasie:dev-ctd2-post

Conversation

@apostasie
Copy link
Copy Markdown
Contributor

@apostasie apostasie commented Aug 9, 2024

This PR is a small follow-up to #3173 and addresses three things:

  • docs.go syntax nit (go.mod update to containerd v2 #3173 (review))
  • cleaning / reordering imports for consistency
  • getting rid of docker/errdefs (used in three locations, two of them being linked, and the third one being just a mistake)

@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Aug 9, 2024
@AkihiroSuda
Copy link
Copy Markdown
Member

Needs rebase

Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@apostasie
Copy link
Copy Markdown
Contributor Author

Thanks as usual @AkihiroSuda

Really appreciate all your help in getting stuff done in the past few months.

I came here just to fix a couple of problems I had with nerdctl - and I stayed because of you folks.

@AkihiroSuda AkihiroSuda merged commit 3f305eb into containerd:main Aug 10, 2024
@apostasie apostasie deleted the dev-ctd2-post branch August 10, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants