Skip to content

Kubernetes minor cleanup (rename and -f on delete)#3338

Merged
fahedouch merged 1 commit intocontainerd:mainfrom
apostasie:f-dev-kube-ci-aftermath
Aug 24, 2024
Merged

Kubernetes minor cleanup (rename and -f on delete)#3338
fahedouch merged 1 commit intocontainerd:mainfrom
apostasie:f-dev-kube-ci-aftermath

Conversation

@apostasie
Copy link
Copy Markdown
Contributor

This is to address @fahedouch belated comments on #3296

Specifically:

  • pass -f to kubectl delete to speed up the teardown routine
  • rename "Kube" to "K8s" for clarity

PTAL at your convenience.

@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Aug 22, 2024
@AkihiroSuda
Copy link
Copy Markdown
Member

rename "Kube" to "K8s" for clarity

Sounds less clear in my feeling

@apostasie
Copy link
Copy Markdown
Contributor Author

rename "Kube" to "K8s" for clarity

Sounds less clear in my feeling

@fahedouch ^

@AkihiroSuda what about just "kubernetes"? That avoids the possible confusion with kubectl that fahedouch was probably wary of, and is better than k8s.

@AkihiroSuda
Copy link
Copy Markdown
Member

SGTM

Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie apostasie force-pushed the f-dev-kube-ci-aftermath branch from 7b357fc to 031aa1d Compare August 22, 2024 02:38
@apostasie
Copy link
Copy Markdown
Contributor Author

SGTM

Ok, should be fine, but let's wait for the kubernetes action to finish.

@apostasie apostasie changed the title K8s minor cleanup (rename and -f on delete) Kubernetes minor cleanup (rename and -f on delete) Aug 22, 2024
@apostasie
Copy link
Copy Markdown
Contributor Author

Failure is unrelated (TestIPFSComposeUp which is really driving me totally bonkers)

@AkihiroSuda AkihiroSuda requested a review from fahedouch August 23, 2024 06:45
Copy link
Copy Markdown
Member

@fahedouch fahedouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fahedouch fahedouch merged commit a7db774 into containerd:main Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants