Skip to content

Login & authentication rework, part 2: prompt cleanup#3392

Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom
apostasie:dev-login-2
Sep 4, 2024
Merged

Login & authentication rework, part 2: prompt cleanup#3392
AkihiroSuda merged 1 commit intocontainerd:mainfrom
apostasie:dev-login-2

Conversation

@apostasie
Copy link
Copy Markdown
Contributor

This is a small PR that comes on top of #3293 and should be merged after it, in preparation for more login cleanup.

Its purpose is solely to isolate user input prompting cleanly, and provide proper error reporting for it.

This is purely refactoring and cleanup.

@apostasie apostasie changed the title Login & authentication rework, part 2: prompt cleanup [WIP] Login & authentication rework, part 2: prompt cleanup Sep 1, 2024
@apostasie apostasie marked this pull request as ready for review September 1, 2024 23:43
@apostasie apostasie changed the title [WIP] Login & authentication rework, part 2: prompt cleanup Login & authentication rework, part 2: prompt cleanup Sep 1, 2024
@apostasie
Copy link
Copy Markdown
Contributor Author

Will rebase once Part 1 lands.

Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie
Copy link
Copy Markdown
Contributor Author

Rebased.
CI is green.

@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Sep 4, 2024
@AkihiroSuda AkihiroSuda added the area/login authentification/ login label Sep 4, 2024
@AkihiroSuda AkihiroSuda merged commit 53d898d into containerd:main Sep 4, 2024
@AkihiroSuda
Copy link
Copy Markdown
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/login authentification/ login

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants