Login refactor (small breakout): hostsstore resolution cleanup

[apostasie]

Fix #3047

Commit message for details.

This is not testable yet (IIRC, because of the way we currently resolve authentication), but I will add tests for this specific condition later on in another upcoming "login" PR.

[apostasie]

CI failure appears to be a network fluke.

[apostasie]

Gentle ping on this.
Although there is no rush - as login rewrite is still pending the design document to be reviewed - would be nice to get this in.

[AkihiroSuda]

Thanks

[nakamorichi]

@apostasie @AkihiroSuda This may have broken repository authentication (currently not able to confirm due to lack of time).

When doing nerdctl login, the repo address in ~/.docker/config.json ends up with port, and at least authentication to ECR fails. When removing the port manually, ECR auth works. Could be also ECR issue, though. I started experiencing the issue recently, but can't pinpoint exact time or particular change as I upgraded various components in my build environment recently.

EDIT: I'm using v2.0.0-rc.2, but maybe this change is not yet merged there? In that case, the issue is related to something else (perhaps some issue mentioned in #3072 ).

[apostasie]

@nakamorichi will look asap tomorrow.

[apostasie]

@nakamorichi confirming this change here has not made it to any rc.
I would still like to look into your problem.
Can you open an issue with details on how to reproduce?

thanks

[apostasie]

@nakamorichi
Using the latest main, things work for me with the following:

aws ecr-public get-login-password --region us-east-1 | nerdctl login --username AWS --password-stdin public.ecr.aws

(works as well with private repositories)

If you are still facing issues, as suggested, you should open a new ticket, with details on what exactly you are doing / how to reproduce.
Thanks.

[nakamorichi]

@apostasie Understood. I'll see if I can find a way to reproduce it. Btw, I'm using lima on macOS Sequoia, but I'm not sure how it could have impact in this case.

[apostasie]

@apostasie Understood. I'll see if I can find a way to reproduce it. Btw, I'm using lima on macOS Sequoia, but I'm not sure how it could have impact in this case.

Am on Lima too (and whatever is macOS latest).
I do not think it would - very curious about your problem though - lmk if you investigate more)