Test rework, part 2#3455
Merged
AkihiroSuda merged 3 commits intocontainerd:mainfrom Sep 27, 2024
Merged
Conversation
e5cec64 to
4501e0f
Compare
Contributor
Author
|
@AkihiroSuda let's merge this if these changes are fine with you. |
4501e0f to
c4df738
Compare
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
c4df738 to
32337e8
Compare
Contributor
Author
|
Last push does rebase, and simplify completion-test to not flake. |
32337e8 to
ef7d7d6
Compare
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
ef7d7d6 to
0aef2f2
Compare
Contributor
Author
|
Failures with last push are the perennial IPFS/Compose, and testattach (current delay is definitely too short - will fix separately at 5 seconds which seems to do the trick). |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first follow-up to #3418, rewriting more tests to leverage the new tooling.
In almost all cases, this is "identical" with the previous state of affairs, as these changes are not meant to introduce new tests, and normally do not radically change the existing tests intention.
However, here or in upcoming follow-ups:
I appreciate this is hard to review.
This is a full-on rewrite.
But then, we are talking solely about tests here, with no code or logic change - and the proof is in the pudding: aka green CI.
I am splitting different subfolders tests in different commits.
As I am converting more tests, I will add more commits to this branch.
We should still merge this PR whenever convenient (pending green of course) - and I will just open more PRs - that should help keep this bite-size and avoid conflicting with main.