Fix IPFS missing layer issue#3490
Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom Oct 4, 2024
Merged
Conversation
apostasie
commented
Oct 3, 2024
| imageService := client.ImageService() | ||
| img, err := imageService.Get(ctx, srcName) | ||
| if err != nil { | ||
| fmt.Println("Failed getting imageservice") |
Contributor
Author
There was a problem hiding this comment.
Leftovers from initial implementation.
apostasie
force-pushed
the
bug-3489-ipfs-missing-layer
branch
from
56607a0 to
bb7b261
Compare
Contributor
Author
|
@AkihiroSuda logging out. Assuming this is green, it is good to go. |
ktock
reviewed
Oct 3, 2024
Member
ktock
left a comment
ktock
left a comment
There was a problem hiding this comment.
Thanks, LGTM. Left a comment on the test code.
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
apostasie
force-pushed
the
bug-3489-ipfs-missing-layer
branch
from
bb7b261 to
703bd58
Compare
Contributor
Author
Thanks a lot @ktock. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3489
This will address part of #3396
The other identified parts so far are: