[fix] fix image filter with nonexist image#3544
Merged
djdongjin merged 1 commit intocontainerd:mainfrom Oct 17, 2024
Merged
Conversation
xyz-li
force-pushed
the
main
branch
5 times, most recently
from
3060371 to
a8aaa0f
Compare
djdongjin
reviewed
Oct 15, 2024
djdongjin
reviewed
Oct 16, 2024
Comment on lines
+169
to
+170
| //nolint:stylecheck | ||
| return []images.Image{}, fmt.Errorf("No such image: %s", parseImageName(before)) |
Contributor
Author
There was a problem hiding this comment.
"No such image: aaaa:latest" is the output of docker. If don't add this nolint, then golint-ci won't pass, or we can change the output.
Member
There was a problem hiding this comment.
If don't add this nolint, then golint-ci won't pass
what's the error message from golint-ci? (Or you mean "No such image: aaaa:latest" is the output of docker. is the error message from golint-ci?)
Contributor
Author
There was a problem hiding this comment.
Running [/home/runner/golangci-lint-1.61.0-linux-amd64/golangci-lint run --verbose] in [/home/runner/work/nerdctl/nerdctl] ...
Error: pkg/imgutil/filtering.go:163:30: ST1005: error strings should not be capitalized (stylecheck)
return []images.Image{}, fmt.Errorf("No such image: %s", fetchImageNames(before))
^
Error: pkg/imgutil/filtering.go:179:30: ST1005: error strings should not be capitalized (stylecheck)
return []images.Image{}, fmt.Errorf("No such image: %s", fetchImageNames(since))
795e114 to
22f5226
Compare
Signed-off-by: xyz-li <hui0787411@163.com>
djdongjin
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3511
This commit does not cover this situation
nerdctl images -f since=IMAGE_ID