Fix semantic of Fail to not care about exit code#3565
Merged
djdongjin merged 1 commit intocontainerd:mainfrom Oct 17, 2024
Merged
Fix semantic of Fail to not care about exit code#3565djdongjin merged 1 commit intocontainerd:mainfrom
djdongjin merged 1 commit intocontainerd:mainfrom
Conversation
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small change broken out of #3550 which is pending review (will rebase once this is in).
Fail()is not expected to verify the exitcode, just that the task fail.This is specifically important as Docker often returns 127 instead of 1 in certain conditions.