Skip to content

Fix ensurecontainerstarted logic and better debug#3573

Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom
apostasie:test-ensure
Oct 18, 2024
Merged

Fix ensurecontainerstarted logic and better debug#3573
AkihiroSuda merged 1 commit intocontainerd:mainfrom
apostasie:test-ensure

Conversation

@apostasie
Copy link
Copy Markdown
Contributor

Breakout of #3535

This fixes logic issues in hasty porting of EnsureContainerStarted, and enhances debugability.

@apostasie apostasie marked this pull request as draft October 18, 2024 20:18
@apostasie apostasie mentioned this pull request Oct 18, 2024
@apostasie apostasie marked this pull request as ready for review October 18, 2024 20:47
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Oct 18, 2024
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Oct 18, 2024
Comment thread pkg/testutil/test/command.go
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit e97fe5a into containerd:main Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci e.g., CI failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants