Skip to content

Rewrite container_stats tests#3615

Merged
AkihiroSuda merged 1 commit into
containerd:mainfrom
apostasie:series-11
Nov 1, 2024
Merged

Rewrite container_stats tests#3615
AkihiroSuda merged 1 commit into
containerd:mainfrom
apostasie:series-11

Conversation

@apostasie
Copy link
Copy Markdown
Contributor

@apostasie apostasie commented Oct 30, 2024

On top of #3617

@apostasie apostasie changed the title Rewrite container_stats tests [BROKEN] Rewrite container_stats tests Oct 30, 2024
@apostasie apostasie force-pushed the series-11 branch 2 times, most recently from 3e465b9 to 78e9e9e Compare October 30, 2024 20:29
@apostasie apostasie changed the title [BROKEN] Rewrite container_stats tests Rewrite container_stats tests Oct 30, 2024
@apostasie apostasie changed the title Rewrite container_stats tests [BROKEN] Rewrite container_stats tests Oct 30, 2024
@apostasie apostasie marked this pull request as ready for review October 31, 2024 13:18
@apostasie apostasie changed the title [BROKEN] Rewrite container_stats tests Rewrite container_stats tests Oct 31, 2024
Comment thread cmd/nerdctl/container/container_stats_test.go Outdated
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Nov 1, 2024
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Nov 1, 2024
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie
Copy link
Copy Markdown
Contributor Author

Failure is part of the legacy/flaky tests (usual TestComposeUp).

Can you poke the CI for a retry?

Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 5c0f90f into containerd:main Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci e.g., CI failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants