Fix test leaking tagged Alpine image#3618
Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom Oct 30, 2024
Merged
Conversation
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
apostasie
added a commit
to apostasie/nerdctl
that referenced
this pull request
Oct 31, 2024
Fixed in containerd#3618 Signed-off-by: apostasie <spam_blackhole@farcloser.world>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is/was leaking busybox tagged as alpine.
Further tests that would call
run alpinewould then not pull, since the image is already here.But then - see #3617 - if said test was to
run -d sleep inf- it would fail silently, because the version of busybox we are using has an oldsleepthat does not supportinf, causing cascading errors into unrelated commands.