Add Infinity constant to enable windows tests with old busybox#3631
Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom Nov 4, 2024
Merged
Add Infinity constant to enable windows tests with old busybox#3631AkihiroSuda merged 1 commit intocontainerd:mainfrom
AkihiroSuda merged 1 commit intocontainerd:mainfrom
Conversation
Contributor
Author
|
Geez. |
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Merged
Member
FYI |
Member
|
Merged via #3624 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Despite having recently updated busybox to a more recent version that does support
sleep inf(#3617), it seems like the windows version of it that we depend on still does not.(if you do have a windows rig available and can investigate what is going on here that would be lovely)
Making more tests available for windows would thus require that we replace all calls to sleep inf or sleep infinity with sleep ARBITRARY_NUMBER.
This is not so good as it would be confusing if the duration is meaningful or not, and as different tests will likely start using different arbitrary numbers.
So this PR suggests we use a constant instead,
Infinity, hiding the fact that we (for now) make this3600.