[WINDOWS] updated busybox image & registry image#3636
[WINDOWS] updated busybox image & registry image#3636apostasie wants to merge 1 commit intocontainerd:mainfrom
Conversation
739e2c4 to
75ae59c
Compare
ccae35d to
a0d8655
Compare
d8e0b91 to
d0b00af
Compare
02830b1 to
c43a038
Compare
|
@AkihiroSuda @djdongjin @fahedouch et al: would like team opinion on this. Problems:
This PR is doing two things:
PR #3579 (WIP) uses both of these test images as a sanity check. Before I put more work in this, I would like to know: a. is this a direction we want to pursue? Thanks. |
|
TODO/missing:
|
a7812f6 to
e4025f8
Compare
👍
👍 But this CI job does not need to run for every main commit. |
|
Thanks for the feedback.
For sure. Let me get this in shape and will ping again when it is ready for review. |
0e382d7 to
cfc7036
Compare
|
Windows nerds, questions for you (tagging the usual suspects @sondavidb and @jsturtevant ) (is @yankay a windows nerd?)
Either this is a change compared to previous versions of nanoserver, or the windows busybox image we had previously was forcing Currently, I am going for compatibility, meaning I am forcing admin in https://github.com/containerd/nerdctl/pull/3636/files#diff-0a09737c4052666fccb706d792f24be6f876a77dcf12eeb7b9ccaacc249a5bf1R138 Is this the right approach? Or should we instead go with nanoserver default and adapt the tests instead?
|
62344d5 to
aa1cfcf
Compare
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
|
Closing for now. |
No description provided.