Skip to content

CI: test framework, part III #3910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AkihiroSuda merged 4 commits into from
Mar 3, 2025
Merged

CI: test framework, part III #3910

AkihiroSuda merged 4 commits into from
Mar 3, 2025

Conversation

@apostasie
Copy link
Contributor

@apostasie apostasie commented Feb 22, 2025 •
edited
Loading

On top of #3890

This is the last PR on breaking out the testing framework.

This one is mostly cosmetic, and has three commits:

  • minor Makefile tweaks (enable freebsd task, etc)
  • more stringent linter settings and corresponding linting
  • move to creack pty

@apostasie
Copy link
Contributor Author

apostasie commented Feb 22, 2025

Rootless failure is #3513

@apostasie
Copy link
Contributor Author

apostasie commented Feb 22, 2025 •
edited
Loading

Rootless slirp4netns failure I have not seen before - some compose race condition (TestComposeUpWithBypass4netns)

@apostasie apostasie marked this pull request as ready for review February 22, 2025 04:09
@apostasie apostasie marked this pull request as draft February 22, 2025 04:47
@apostasie apostasie changed the title Test framework, part III [PENDING DEPENDENT] Test framework, part III Feb 22, 2025
@apostasie apostasie force-pushed the sub-project-testing-3 branch from a7c43cb to 332c0cf Compare February 22, 2025 20:03
@apostasie apostasie changed the title [PENDING DEPENDENT] Test framework, part III [PENDING DEPENDENT] CI: test framework, part III Feb 23, 2025
@apostasie apostasie force-pushed the sub-project-testing-3 branch 2 times, most recently from 61c2b1a to 9d1700a Compare February 27, 2025 16:42
@apostasie apostasie changed the title [PENDING DEPENDENT] CI: test framework, part III CI: test framework, part III Feb 27, 2025
@apostasie apostasie marked this pull request as ready for review February 27, 2025 17:09
@AkihiroSuda AkihiroSuda added this to the v2.0.4 milestone Feb 28, 2025
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Feb 28, 2025
AkihiroSuda
AkihiroSuda reviewed Feb 28, 2025
View reviewed changes
AkihiroSuda
AkihiroSuda reviewed Feb 28, 2025
View reviewed changes
AkihiroSuda
AkihiroSuda reviewed Feb 28, 2025
View reviewed changes
AkihiroSuda
AkihiroSuda reviewed Feb 28, 2025
View reviewed changes
@apostasie apostasie force-pushed the sub-project-testing-3 branch 6 times, most recently from da0ff89 to 584d0ce Compare February 28, 2025 18:53
@apostasie
Copy link
Contributor Author

apostasie commented Feb 28, 2025

Done addressing comments.
Also rebased.

@apostasie
Copy link
Contributor Author

apostasie commented Feb 28, 2025 •
edited
Loading

Failing test may or may not be related (monolog in #3952) - it is about pty.

@apostasie
Copy link
Contributor Author

apostasie commented Mar 1, 2025

Let's merge #3953 first.

@apostasie apostasie force-pushed the sub-project-testing-3 branch from 584d0ce to c81dfe9 Compare March 3, 2025 03:06
apostasie added 3 commits March 2, 2025 19:18
@apostasie
Makefile fixes
0020c91 
- enable freebsd tasks
- use ORG_PREFIXES consistently

Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie
Move to creack pty
7f04990 
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie
Lint fixes
077558c 
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie
Add golangci and yamllint to tigron
62c1565 
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie apostasie force-pushed the sub-project-testing-3 branch from c81dfe9 to 62c1565 Compare March 3, 2025 03:18
@apostasie
Copy link
Contributor Author

apostasie commented Mar 3, 2025

Rebased and recommited to cleaner commits.

Pending CI.

@apostasie
Copy link
Contributor Author

apostasie commented Mar 3, 2025 •
edited
Loading

Failure https://github.com/containerd/nerdctl/actions/runs/13622696958/job/38074815721?pr=3910 is unrelated (see #3960).

I am going to re-run the CI repeatedly on this.

Not 100% comfortable about moving to creack pty and want to make sure we do not introduce something flaky.

@apostasie apostasie closed this Mar 3, 2025
@apostasie apostasie reopened this Mar 3, 2025
@apostasie
Copy link
Contributor Author

apostasie commented Mar 3, 2025

Failure https://github.com/containerd/nerdctl/actions/runs/13623206964/job/38076117848?pr=3910#step:9:483 is ongoing connectivity issues with ghcr.

@apostasie apostasie closed this Mar 3, 2025
@apostasie apostasie reopened this Mar 3, 2025
@apostasie
Copy link
Contributor Author

apostasie commented Mar 3, 2025

Failure https://github.com/containerd/nerdctl/actions/runs/13624188491/job/38078518278?pr=3910#step:8:549

TestRunCopyingUpInitialContentsShouldNotResetTheCopiedContents. Looks like a builder bug error: failed to solve: Internal: not found.

Unrelated.

@apostasie apostasie closed this Mar 3, 2025
@apostasie apostasie reopened this Mar 3, 2025
AkihiroSuda
AkihiroSuda approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit f364f24 into containerd:main Mar 3, 2025
117 of 120 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

area/ci e.g., CI failure

Projects

None yet

Milestone

v2.0.4

Development

Successfully merging this pull request may close these issues.

2 participants

@apostasie @AkihiroSuda