test: refactor container_run_windows_test.go to use Tigron#4729
Merged
ChengyuZhu6 merged 1 commit intocontainerd:mainfrom Feb 5, 2026
Merged
Conversation
JoonsooWon
commented
Jan 31, 2026
| testCase.Run(t) | ||
| } | ||
|
|
||
| func TestRunHostProcessContainerAsService(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
I renamed TestRunHostProcessContainerAsService to TestRunHostProcessContainerAsLocalService because I thought this would be clearer.
JoonsooWon
commented
Jan 31, 2026
| testCase.Run(t) | ||
| } | ||
|
|
||
| func TestRunHostProcessContainerAslocalService(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
I renamed TestRunHostProcessContainerAslocalService to TestRunHostProcessContainerAsNetworkService because of same reason
JoonsooWon
force-pushed
the
issues_4613_container_run_windows_test.go
branch
from
3dbf128 to
33fca9b
Compare
Signed-off-by: Joonsoo Won <wonjs0116@gmail.com>
JoonsooWon
force-pushed
the
issues_4613_container_run_windows_test.go
branch
from
33fca9b to
4129b80
Compare
46 tasks
ChengyuZhu6
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related : #4613