Skip to content

Conversation

@ningmingxiao
Copy link
Contributor

Signed-off-by: ningmingxiao ning.mingxiao@zte.com.cn

@AkihiroSuda
Copy link
Member

Thanks, but this needs tests.

Also, I guess we don't support attaching multiple terminals to a single container and we have to document that.

@ningmingxiao
Copy link
Contributor Author

I use nerdctl run a container and then nerdctl attach it,it will not work.
but use crictl run a container then nerdctl attach it will work

@AkihiroSuda
Copy link
Member

I use nerdctl run a container and then nerdctl attach it,it will not work. but use crictl run a container then nerdctl attach it will work

Please document that in README.md and nerdctl attach --help

Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
@fahedouch
Copy link
Member

fahedouch commented Jun 12, 2022

@ningmingxiao are you planning to continue working on his PR ?

@ningmingxiao
Copy link
Contributor Author

ningmingxiao commented Jun 13, 2022

@ningmingxiao are you planning to continue working ont his PR ?

when i use nerdctl run a container then i use nerdctl attach it, but it will not work, but if i use crictl run a container then nerdctl attach will work well, so i can't wirte testcase ,do you have some advices? @fahedouch @AkihiroSuda

@junnplus
Copy link
Member

nerdctl run -d different from crictl/ctr tools, IO sets of task is a log URI. see https://github.com/containerd/nerdctl/blob/master/pkg/taskutil/taskutil.go#L54-L60

@fahedouch fahedouch added the enhancement New feature or request label Jul 16, 2022
@AkihiroSuda
Copy link
Member

Closing, as we merged #2108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request status/needs-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants