fix can't start with -it flag#950
Closed
ningmingxiao wants to merge 1 commit into
Closed
Conversation
d3bdaa0 to
5dbb7d9
Compare
Contributor
Author
|
fix #492 |
Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
Member
|
|
AkihiroSuda
reviewed
Apr 5, 2022
| return errors.New("got nil con with flagT=true") | ||
| } | ||
| taskCIO = cio.NewCreator(cio.WithStreams(con, con, nil), cio.WithTerminal) | ||
| } |
Member
There was a problem hiding this comment.
For consistency with Docker, we have to detach tty
Contributor
Author
There was a problem hiding this comment.
what should I do? change from return errors.New("got nil con with flagT=true") to return errors.New("got nil con")?
Member
There was a problem hiding this comment.
Probably you should attach a dummy terminal, not the real terminal, to emulate Docker's behavior.
Needs further investigation.
Member
|
Fixed by #1642 ? |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ningmingxiao ning.mingxiao@zte.com.cn