Skip to content

add returned include dir as --proto_path#23

Merged
stevvooe merged 1 commit intocontainerd:masterfrom
justai-net:add_include_dir_as_proto_path
Feb 1, 2019
Merged

add returned include dir as --proto_path#23
stevvooe merged 1 commit intocontainerd:masterfrom
justai-net:add_include_dir_as_proto_path

Conversation

@justai-net
Copy link
Copy Markdown
Contributor

Attempt to fix other issues around #8

protoc --decode google.protobuf.FileDescriptorSet /usr/local/include/google/protobuf/descriptor.proto
/usr/local/include/google/protobuf/descriptor.proto: File does not reside within any path specified using --proto_path (or -I).  You must specify a --proto_path which encompasses this file.  Note that the proto_path must be an exact prefix of the .proto file names -- protoc is too dumb to figure out when two paths (e.g. absolute and relative) are equivalent (it's harder than you think).

Will now perform

protoc -I /path/to --decode google.protobuf.FileDescriptorSet /path/to/google/protobuf/descriptor.proto

Signed-off-by: Adam Inthapanya adam.int@live.com

@rohanray
Copy link
Copy Markdown

@justai-net @stevvooe This PR works for me.

Copy link
Copy Markdown
Member

@stevvooe stevvooe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevvooe stevvooe merged commit 6933852 into containerd:master Feb 1, 2019
@justai-net justai-net deleted the add_include_dir_as_proto_path branch February 8, 2019 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants