Support multiple generators#45
Merged
stevvooe merged 1 commit intocontainerd:mainfrom Oct 19, 2021
Merged
Conversation
kzys
force-pushed
the
generators
branch
5 times, most recently
from
d0ca12b to
764614f
Compare
kzys
changed the title
AkihiroSuda
reviewed
Sep 25, 2021
|
|
||
| type config struct { | ||
| Version string | ||
| Generator string |
Member
There was a problem hiding this comment.
Would it be possible to keep compatibility with the previous syntax?
Member
Author
There was a problem hiding this comment.
The latest revision should support both Generator and Generators. The former is converted to the latter internally.
kzys
force-pushed
the
generators
branch
5 times, most recently
from
5aff242 to
bde1693
Compare
Member
Author
|
@AkihiroSuda @stevvooe Could you take a look? |
dmcgowan
reviewed
Oct 5, 2021
| Plugins []string | ||
| Includes struct { | ||
|
|
||
| // Plugins will be deprecated. It has to be per-Generator setting, but neither protoc-gen-go nor protoc-gen-go-grpc |
Member
There was a problem hiding this comment.
The statement about plugin support is a bit hard to understand with the double negative. Is this saying both support plugins?
Member
Author
There was a problem hiding this comment.
Oh. That was simply wrong. It has to be
but neither protoc-gen-go nor protoc-gen-go-grpc support plugins
The latest version of protoc-gen-go doesn't support gRPC. Supporting multiple generators is the way to support gRPC going forward. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
dmcgowan
approved these changes
Oct 5, 2021
stevvooe
approved these changes
Oct 19, 2021
Member
stevvooe
left a comment
stevvooe
left a comment
There was a problem hiding this comment.
LGTM
Is it time to start versioning the config?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest version of protoc-gen-go doesn't support gRPC. Supporting multiple generators is the way to support gRPC going forward.