Remove plugins and import_path#48
Merged
estesp merged 2 commits intocontainerd:mainfrom Oct 25, 2021
Merged
Conversation
kzys
force-pushed
the
upgrade-proto
branch
10 times, most recently
from
3a56327 to
c6279f7
Compare
kzys
commented
Oct 20, 2021
| {{- end -}},{{- end -}} | ||
| import_path={{$.ImportPath}} | ||
| {{- end -}} | ||
| {{- range $index, $name := .Names }} --{{- $name -}}_out={{- $.OutputDir }}{{- end -}} |
Member
Author
There was a problem hiding this comment.
Now we need to think about either
- Versioning (e.g. make this version as
2and reject Protobuild.toml file that hasversion=unstable. - Check unsupported fields (e.g. Plugins) and error out
- Keep 2 code paths and switch based on version.
What do you think? I'm currently inclined to do 1 since it makes code simpler for us.
kzys
force-pushed
the
upgrade-proto
branch
15 times, most recently
from
f22d463 to
45e2637
Compare
kzys
commented
Oct 20, 2021
| expected: "protoc -I --go_out=import_path= --go-grpc_out=import_path=:", | ||
| name: "use protoc-gen-go-grpc instead of plugins", | ||
| cmd: protocCmd{Names: []string{"go", "go-grpc"}}, | ||
| expectedV1: "protoc -I --go_out=import_path=: --go-grpc_out=import_path=:", |
Member
Author
There was a problem hiding this comment.
It seems the previous test was wrong. --go_out=import_path= must have :.
kzys
force-pushed
the
upgrade-proto
branch
5 times, most recently
from
c21ad6f to
e0c0e3a
Compare
estesp
approved these changes
Oct 21, 2021
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM; one minor spelling nit in a comment.
A follow-up PR that updates the README overall might be good; looks like a few comments there may no longer be valid or just simply outdated
added 2 commits
October 21, 2021 09:53
This change introduces version=2 that supports latest protoc, protoc-gen-go and protoc-gen-go-grpc. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
This change extends GitHub Actions to test Protobuild against multiple protoc-gen-go versions. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
dmcgowan
approved these changes
Oct 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kazuyoshi Kato katokazu@amazon.com