chore: bump versions of the containerd-shim-wasm to 0.4 and shims to 0.3#370
chore: bump versions of the containerd-shim-wasm to 0.4 and shims to 0.3#370Mossaka merged 2 commits intocontainerd:mainfrom
0.4 and shims to 0.3#370Conversation
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Mossaka
requested review from
devigned,
jprendes and
jsturtevant
and removed request for
jprendes and
jsturtevant
| [workspace.package] | ||
| edition = "2021" | ||
| version = "0.2.0" | ||
| version = "0.3.0" |
There was a problem hiding this comment.
question: Should we bump this to 0.4 so that it matches the lib version? Should we always keep these two the same?
I believe there's been previous discussions on this topic before, is that correct?
There was a problem hiding this comment.
I don't recall a previous discussions on this topic. I am okay with either ways.
Should we always keep these two the same?
Maybe not as crates and binaries can evolve independently imo.
There was a problem hiding this comment.
I think there was a discussion on keeping the release of each shim, as well as the lib, independent, as their versions could diverge.
(I haven't searched as I'm on mobile at the moment)
|
Bump containerd-shim to 0.6.0 to include structured logging. This PR will close #349 |
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
it won't close it but enable it. The PR will include timestamps on our logs though 🥳 |
|
LGTM |
3 participants
No description provided.