Skip to content

Re-enable TaskResize test in CI#176

Closed
jsturtevant wants to merge 1 commit intocontainerd:mainfrom
jsturtevant:enabletaskresize
Closed

Re-enable TaskResize test in CI#176
jsturtevant wants to merge 1 commit intocontainerd:mainfrom
jsturtevant:enabletaskresize

Conversation

@jsturtevant
Copy link
Copy Markdown
Contributor

@jsturtevant jsturtevant commented Aug 10, 2023

Testing the failing tests in local environment for #122 I found this test passes. Trying it in CI.

Signed-off-by: James Sturtevant <jstur@microsoft.com>
@github-actions github-actions Bot added the T-CI Changes in project's CI label Aug 10, 2023
Copy link
Copy Markdown
Member

@Burning1020 Burning1020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests occurred by chance. May need to run it several times to potentially replicate the the problem.

@jsturtevant
Copy link
Copy Markdown
Contributor Author

jsturtevant commented Aug 11, 2023

interesting, I ran this specific test a bunch of times locally but I will see if I can reproduce running in a loop locally. I don't ability to re-trigger the jobs here so might do that on my branch as well.

@jsturtevant
Copy link
Copy Markdown
Contributor Author

I ran this single, specific test 100 times successfully. Will try a few more times and also try in CI with all the tests running incase its a issue when running with everything:

=== RUN   TestTaskResize
=== PAUSE TestTaskResize
=== CONT  TestTaskResize
--- PASS: TestTaskResize (1.10s)
ok      github.com/containerd/containerd/integration/client     2.704s
make integration completed successfully for 100 attempts.

@jsturtevant
Copy link
Copy Markdown
Contributor Author

jsturtevant commented Aug 11, 2023

I got it on the 190th run locally:

INFO[0000] start to pull seed image                      image="ghcr.io/containerd/busybox:1.32"
=== RUN   TestTaskResize
=== PAUSE TestTaskResize
=== CONT  TestTaskResize
    container_test.go:2357: failed to create shim task: ttrpc: closed: unknown

containerd logs confirm it was during create:

time="2023-08-11T16:42:23.441614347Z" level=debug msg="event published" ns=testing topic=/snapshot/prepare type=containerd.events.SnapshotPrepare
time="2023-08-11T16:42:23.447312550Z" level=debug msg="get snapshot mounts" key=TestTaskResize
time="2023-08-11T16:42:23.460445957Z" level=debug msg="event published" ns=testing topic=/containers/create type=containerd.events.ContainerCreate
time="2023-08-11T16:42:23.486143669Z" level=debug msg="get snapshot mounts" key=TestTaskResize
time="2023-08-11T16:42:23.901091473Z" level=debug msg="garbage collected" d=7.965004ms
time="2023-08-11T16:42:27.508985837Z" level=info msg="shim disconnected" id=TestTaskResize

@jsturtevant
Copy link
Copy Markdown
Contributor Author

Needs more investigation, I tried it with the fix that went into ttrpc (containerd/ttrpc-rust#208) but it didn't help. I've added a note to #122

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-CI Changes in project's CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants