Skip to content

[Windows] Retry when pipe is busy#206

Merged
mxpv merged 1 commit intocontainerd:mainfrom
jsturtevant:retry-pipe-busy
Oct 4, 2023
Merged

[Windows] Retry when pipe is busy#206
mxpv merged 1 commit intocontainerd:mainfrom
jsturtevant:retry-pipe-busy

Conversation

@jsturtevant
Copy link
Copy Markdown
Contributor

fixes #153

There is a small chance the pipe connection thread is switching causing the error. This is a retriable error so we should retry it.

@github-actions github-actions Bot added C-shim Containerd shim OS-windows A change is specific to Windows labels Sep 26, 2023
Comment thread crates/shim/src/synchronous/publisher.rs Outdated
@jsturtevant
Copy link
Copy Markdown
Contributor Author

CI failure was:

2023-09-27T16:54:46.0829155Z === CONT  TestContainerAttachProcess
2023-09-27T16:54:46.2301858Z     container_linux_test.go:716: write /proc/self/fd/29: broken pipe
2023-09-27T16:54:46.2314358Z     container_linux_test.go:724: write /proc/self/fd/29: broken pipe
2023-09-27T16:54:46.2384256Z     container_linux_test.go:746: expected output "hello\nhello\n" but received ""
2023-09-27T16:54:46.2591524Z --- FAIL: TestContainerAttachProcess (0.18s)
2023-09-27T16:54:46.2592190Z === CONT  TestContainerAttach
2023-09-27T16:54:46.3625257Z     container_linux_test.go:515: write /proc/self/fd/29: broken pipe
2023-09-27T16:54:46.3637557Z     container_linux_test.go:528: write /proc/self/fd/29: broken pipe
2023-09-27T16:54:46.3876891Z     container_linux_test.go:549: expected output "hello\nhello\n" but received ""
2023-09-27T16:54:46.3910662Z --- FAIL: TestContainerAttach (0.13s)

@mxpv mxpv enabled auto-merge September 27, 2023 19:27
auto-merge was automatically disabled September 27, 2023 19:48

Head branch was pushed to by a user without write access

@jsturtevant jsturtevant force-pushed the retry-pipe-busy branch 2 times, most recently from 6a55324 to 9bc217e Compare September 28, 2023 21:34
Signed-off-by: James Sturtevant <jstur@microsoft.com>
@mxpv mxpv added this pull request to the merge queue Oct 4, 2023
Merged via the queue into containerd:main with commit 75d6dee Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-shim Containerd shim OS-windows A change is specific to Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows connect test flaking with all pipe instances are busy

2 participants