Add support for structured logging#212
Merged
mxpv merged 2 commits intocontainerd:mainfrom Oct 11, 2023
Merged
Conversation
9ee3d0d to
66cfa81
Compare
28fa683 to
8a41a79
Compare
4dae8ff to
ca8cf56
Compare
Signed-off-by: James Sturtevant <jstur@microsoft.com>
Signed-off-by: James Sturtevant <jstur@microsoft.com>
ca8cf56 to
8a83b38
Compare
mxpv
approved these changes
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #210.
Example usage would be:
with the output
Question: Should this be behind a feature flag? The functionality is in
logcrate behindkv_unstable. The major issue would be that the api might change but it is pretty small api that is being used here and it is being used in projects like https://github.com/iorust/structured-logger