Use google.golang.org/grpc/encoding to decode protobuf#90
Closed
kzys wants to merge 1 commit intocontainerd:mainfrom
Closed
Use google.golang.org/grpc/encoding to decode protobuf#90kzys wants to merge 1 commit intocontainerd:mainfrom
kzys wants to merge 1 commit intocontainerd:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 70.75% 73.23% +2.48%
==========================================
Files 11 11
Lines 612 710 +98
==========================================
+ Hits 433 520 +87
- Misses 142 153 +11
Partials 37 37
Continue to review full report at Codecov.
|
kzys
force-pushed
the
bye-gogo
branch
2 times, most recently
from
9d84aee to
60572d0
Compare
Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Member
Author
|
It would be better to do #91 instead of this one, to migrate off from gogo/protobuf completely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kazuyoshi Kato katokazu@amazon.com